Fix issues in guest logging #410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simongdavies
added
the
kind/enhancement
simongdavies
force-pushed
the
fix-logging
branch
from
4c70cc2 to
b106a71
Compare
Signed-off-by: Simon Davies <[email protected]>
…guest log_level if not set The guest log level impacts the amount of logs produced by the guest, its presently set by examining the value of max_log_level in the host. This may not be appropriate since logging in the guest is expensive and it may cause logs to be emitted from the guest but ignored in the host. This change introduces a function on an uninitializedsandbox to set the level explicitly, if this is not set the env var RUST_LOG is parsed to determine the log level so that logs are only produced if they are going to be consumed. If RUST_LOG is not set then the max guest log level is set to error. Signed-off-by: Simon Davies <[email protected]>
simongdavies
force-pushed
the
fix-logging
branch
from
b106a71 to
042bfdf
Compare
dblnz
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow explicit setting of max guest log level, , if this is not set check
RUST_LOGenvironment variable.The guest log level impacts the amount of logs produced by the guest, its presently set by examining the value of max_log_level in the host.
This may not be appropriate since logging in the guest is expensive and it may cause logs to be emitted from the guest but ignored in the host. This change introduces a function on an
UninitializedSandboxto set the level explicitly, if this is not set the env varRUST_LOGis parsed to determine the log level so that logs are only produced if they are going to be consumed. IfRUST_LOGis not set then the max guest log level is set to error.Updates inconsistent crate name
hyperlight-guestin guest logs tohyperlight_guest